Commit Graph

292 Commits

Author SHA1 Message Date
June Tate-Gans
358fb509db g13d: Final-final cleanups to the codebase
- Removing a bunch of silly star comment separates
  - Moving font8x8 back into its own header
  - Move string_repr_out into repr.cc
2021-04-25 17:22:34 -05:00
June Tate-Gans
a05dcb04c8 g13d: More symbol relocations and cleanups
Lots of cross-translation unit messes in here cleaned up finally. This should be
the last change necessary to clean up these refs between translation units.
2021-04-25 17:09:19 -05:00
June Tate-Gans
95b137f3db g13d: Fix the font translation unit name 2021-04-25 16:53:50 -05:00
June Tate-Gans
648c14690f g13d: More cleanups and migrations
Second part of the big refactor. Migrating all of the relevant method bodies to
their respective translation units.
2021-04-25 16:51:41 -05:00
June Tate-Gans
ae6cf5084a g13d: Rework and cleanup namespaces and files
This is the first half of some major rework of the g13d codebase to make things
a bit more manageable. This splits out a great deal of stuff from helper.h into
separate translation units, and also breaks out a great deal of the g13.h header
into separate translation units as well.

Doing this saves in compilation time as we make changes to the system, and also
helps to clean up a whole bunch of leaking symbols.
2021-04-25 16:35:44 -05:00
June Tate-Gans
efe01fb850 g13d: Remove switch and handle all switch cases 2021-04-25 14:40:31 -05:00
June Tate-Gans
9c15e935a7 g13d: Add a blank line 2021-04-25 14:40:16 -05:00
June Tate-Gans
b7f784563c g13d: Fix initialization order 2021-04-25 14:39:54 -05:00
June Tate-Gans
47d876b4cb g13d: Fix a bunch of sign comparisons 2021-04-25 14:39:40 -05:00
June Tate-Gans
9bf95336cc g13d: Remove a bunch of unused vars and definitions 2021-04-25 14:38:41 -05:00
June Tate-Gans
8e14f1f853 g13d: Clean up initialization order 2021-04-25 14:38:08 -05:00
June Tate-Gans
f289bdf850 g13d: Style fixes and remove an unused variable 2021-04-25 14:37:00 -05:00
June Tate-Gans
366e3c0f24 g13d: Remove an unused block of code
We don't actually do anything with an add operation in
G13_Device::_init_commands, so fix up the if block.
2021-04-25 14:36:07 -05:00
June Tate-Gans
cb916e4d24 g13d: Fix a comparison with signed vs. unsigned 2021-04-25 14:35:49 -05:00
June Tate-Gans
d910829930 g13d: More C++11 iteration and exit on no more managed devices
Since we start from udev/systemd these days, we should exit when we don't have
any more devices to manage, and let udev/systemd manage things when a new one is
connected.
2021-04-25 14:33:48 -05:00
June Tate-Gans
d391b647b6 g13d: Fix a bunch of initialization order errors
The initializers were in the wrong order.
2021-04-25 14:33:12 -05:00
June Tate-Gans
65ab987a87 g13d: Simplify G13_Action_Keys::act
Migrate to C++11 iteration and clean up the mess of code that this was
originally with a single call to send_event and a proper use of a ternary for
logging.
2021-04-25 14:32:24 -05:00
June Tate-Gans
bbb3104eaf g13d: Use C++11 iterator instead of a raw C loop
Signed vs. unsigned types throwing all kinds of errors.
2021-04-25 14:31:45 -05:00
June Tate-Gans
19faa21256 g13d: Fix horribly broken strncpy usage
The sizeof was actually using the size of the statically allocated name instead
of the size of the destination. In practice, it's not a problem, but still, it
should be fixed.
2021-04-25 14:30:46 -05:00
June Tate-Gans
ae055495cc g13d: Handle errors in writes
The original code was just throwing away error conditions for write calls to an
fd. Obviously this is bad, but really, we should probably be using an ostream
instead of a raw file handle here. For now, deal with the warning by checking
the result for errors, at least, and later we'll refactor to use ostream
properly.
2021-04-25 14:29:40 -05:00
June Tate-Gans
516423ae16 g13d: Run clang-format to clean things up a bit 2021-04-25 14:04:12 -05:00
June Tate-Gans
70e77c2b3b udev: Actually set the right group
Forgot to set the group for the nodes to input so that the user can manage it if
needed.
2021-04-25 14:01:53 -05:00
June Tate-Gans
cf1caf7c7a g13d: Fix include path for config.h 2021-04-25 13:43:16 -05:00
June Tate-Gans
0cf69f92d2 clangformat: Indent case labels 2021-04-25 13:43:02 -05:00
June Tate-Gans
709f088d8c gitignore: Ignore GNU global tags 2021-04-25 13:42:46 -05:00
June Tate-Gans
c7992d52b5 g13d: Reformat all the files using clang-format
This should help with maintainability.
2021-04-25 12:51:26 -05:00
June Tate-Gans
c32950bfcb g13d: Build with warnings and correct C++ standard 2021-04-25 12:45:25 -05:00
June Tate-Gans
e17abaddf2 g13d: Add a config header 2021-04-25 12:44:58 -05:00
June Tate-Gans
6ea11f3d58 cmake: Install udev and systemd services 2021-04-25 12:20:19 -05:00
June Tate-Gans
b04a8d6152 udev: Match attributes correctly and trigger systemd unit
This starts to make g13d more automatic. Instead of requiring manual
intervention or automatic starts on system start, this will allow udevd to
automatically trigger g13d when a g13 is plugged in.

There's still a bug in g13d where if the device falls off the USB chain g13d
won't exit, though, but this is a good start.
2021-04-25 12:18:07 -05:00
June Tate-Gans
eba5f77a88 g13d.service: Fix the fifo locations
Apparently /var/run is the old, deprecated pathname for /run these days.
2021-04-25 12:17:28 -05:00
June Tate-Gans
05c64f62ed cmake: Make install create /run/g13d
CMake still doesn't have a way to set mode and owner/group at install time
atomically, so we have to fall back and call install directly in a script.
2021-04-25 12:16:47 -05:00
June Tate-Gans
8e8638d08f build: Remove the old Makefile
We need to double down on the cmake build system, so get rid of the old Makefile.
2021-04-25 11:57:52 -05:00
June Tate-Gans
fa82756f3d contrib: Rename to be more accurate 2021-04-25 01:24:02 -05:00
June Tate-Gans
fa73ed6212 udev: Fix the mode and group
The g13 should only be accessible by users in the input group to tighten up
security a bit.
2021-04-25 01:21:58 -05:00
June Tate-Gans
04cb5d9c12 build: Start migration to cmake
This preps us for proper system installs to distributions, finding depending
libraries, and allowing us to build the foundation for the GUI and support
tooling next.

The plan is to run g13d as a system daemon managed by systemd. We'll use the
system-wide input group to control access to the daemon.

  - Add a CMakeLists for etc so we can install the udev rules.
  - Move the src dir to g13d to disambiguate a bit.
  - Update the toplevel Makefile so we can still build the old way (for now).
2021-04-25 01:19:06 -05:00
June Tate-Gans
a8eda7a3c5 readme: Update the header a bit
This makes it clear what the origin of the source was, and what the intent for
it is.
2021-04-25 00:54:34 -05:00
June Tate-Gans
6e41bf4fa3 licensing: Add in the toplevel MIT license
The original source was under the public domain from "ecraven" off of github --
this places the entire tree under the MIT license. In terms of licensing, this
isn't much different from the public domain, except for the indemnity clauses.
2021-04-25 00:51:30 -05:00
June Tate-Gans
4f02eceeb1 warnings: Fix a bunch of warnings
This is in prep to turn on more warnings.

  - Stop using libusb_set_debug, according to the deprecation warning for
    libusb.
  - Return correctly in G13_Manager::run
  - Fix the ostream logging helper to return an ostream instead of just
    returning whatever the last expression was.
2021-04-25 00:37:26 -05:00
June Tate-Gans
b490dd9fff cleanups: Migrate source files to appropriate dirs and fix names
This cleans things up significantly in the source tree and makes this easier to
manage longer term. In the next few commits, we'll migrate the build to CMake in
prep for packaging support.

  - Move bindings into bindings
  - Move system configs and misc files into etc
  - Move LCD apps into contrib/
  - Move all source files into srcs
  - Rename helper extensions to match GNU extension naming, fix the #includes as
    well
  - Adjust Makefile to be less verbose and more programmatic
2021-04-25 00:34:49 -05:00
June Tate-Gans
713b4beefc readme: Cleanups and wrapping fixes
This wraps long lines and removes a bunch of trailing whitespace to make it a
bit more maintainable.
2021-04-24 23:55:58 -05:00
June Tate-Gans
9bf08d1d6d qol fixes: Update Makefile and add systemd unit
This removes the makefile packaging target, since it wasn't really all that
useful for distribution of the program. Additionally, this sets up an install
target to install g13d to the users' local directory.

This is kinda a hack -- really we should be installing g13d to $PREFIX/bin,
dropping a g13d unit somewhere, and then setting up appropriate permissions,
etc. It works for me, though.
2021-04-24 23:50:48 -05:00
James Fowler
815e0001cb Merge pull request #18 from james-fowler/master
oops... forgot a file
2016-01-20 13:38:14 -05:00
James Fowler
26b0e59281 oops... forgot a file 2016-01-20 13:37:00 -05:00
James Fowler
42f22de614 Merge pull request #15 from james-fowler/master
G13++ - and the kitchen sink...
2016-01-20 13:32:49 -05:00
James Fowler
3524fdca4c added log_level control, refactored G13_Device::command 2016-01-20 13:30:48 -05:00
James Fowler
d3349be24e cleanup logging 2015-12-15 15:48:16 -05:00
James Fowler
dfc3c4a6eb message for unrecognized stickzone operation 2015-12-14 12:43:23 -05:00
James Fowler
f11b2eafdd added "dump" diagnostic command, more cleanup 2015-12-14 12:35:56 -05:00
James Fowler
65cf67d8c4 more edits to README 2015-12-14 01:16:22 -05:00