From ab16600463f17e8d46c18b27cfd1436a5c026053 Mon Sep 17 00:00:00 2001
From: Adam R Grey <git@adamrgrey.com>
Date: Sat, 29 Jun 2024 16:45:07 -0400
Subject: [PATCH] inerited channel stats works better

before it would include 1 level, then assume that's the top. so 2 degrees of inheritance would confuse it
---
 .../Controllers/ChannelsController.cs         | 16 ++++++-
 WebInterface/Views/Channels/Details.cshtml    | 42 +++++++++++--------
 2 files changed, 38 insertions(+), 20 deletions(-)

diff --git a/WebInterface/Controllers/ChannelsController.cs b/WebInterface/Controllers/ChannelsController.cs
index 326376a..9a91891 100644
--- a/WebInterface/Controllers/ChannelsController.cs
+++ b/WebInterface/Controllers/ChannelsController.cs
@@ -27,7 +27,16 @@ public class ChannelsController : Controller
     {
         if(_db.Channels == null)
             return Problem("Entity set '_db.Channels' is null.");
-        var channel = await _db.Channels.Include(u => u.SubChannels).Include(u => u.Users).Include(u => u.ParentChannel).FirstAsync(u => u.Id == id);
+        //"but adam", says the strawman, "why load *every* channel and walk your way up? surely there's a .Load command that works or something."
+        //eh. I checked. Not really. You could make an SQL view that recurses its way up, meh idk how. You could just eagerly load *every* related object...
+        //but that would take in all the messages. 
+        //realistically I expect this will have less than 1MB of total "channels", and several GB of total messages per (text) channel.
+        var AllChannels = await _db.Channels
+            .Include(u => u.SubChannels)
+            .Include(u => u.Users)
+            .Include(u => u.ParentChannel)
+            .ToListAsync();
+        var channel = AllChannels.First(u => u.Id == id);
         var walker = channel;
         while(walker != null)
         {
@@ -35,7 +44,10 @@ public class ChannelsController : Controller
                 ViewData["breadcrumbs"];
             walker = walker.ParentChannel;
         }
-        return View(channel);
+        return View(
+            new Tuple<Channel, Enumerations.LewdnessFilterLevel, Enumerations.MeannessFilterLevel>(
+                channel, channel.EffectivePermissions.LewdnessFilterLevel, channel.EffectivePermissions.MeannessFilterLevel
+            ));
     }
 
     [ResponseCache(Duration = 0, Location = ResponseCacheLocation.None, NoStore = true)]
diff --git a/WebInterface/Views/Channels/Details.cshtml b/WebInterface/Views/Channels/Details.cshtml
index 342ffb2..ab338a8 100644
--- a/WebInterface/Views/Channels/Details.cshtml
+++ b/WebInterface/Views/Channels/Details.cshtml
@@ -1,6 +1,12 @@
 @using System.ComponentModel
 @using Newtonsoft.Json
-@model Channel
+@model Tuple<Channel, Enumerations.LewdnessFilterLevel, Enumerations.MeannessFilterLevel>
+@{
+  var ThisChannel = Model.Item1;
+  var IfInheritedLewdnessFilterLevel = Model.Item2;
+  var IfInheritedMeannessFilterLevel = Model.Item3;
+}
+
 
 @Html.Raw(ViewData["breadcrumbs"])
 
@@ -8,21 +14,21 @@
   <tbody>
     <tr>
       <th scope="row">Display Name</th>
-      <td>@Model.DisplayName</td>
+      <td>@ThisChannel.DisplayName</td>
     </tr>
     <tr>
       <th scope="row">Channel type</th>
-      <td>@(Model.ChannelType != null ? Enumerations.GetDescription(Model.ChannelType) : "?")</td>
+      <td>@(ThisChannel.ChannelType != null ? Enumerations.GetDescription(ThisChannel.ChannelType) : "?")</td>
     </tr>
     <tr>
       <th scope="row">Lewdness Filter Level</th>
       <td>
         <select name="LewdnessFilterLevel" id="LewdnessFilterLevel" onchange="patchModel(jsonifyChannel())">
-          <!option value="" @(Model.LewdnessFilterLevel == null ? "selected" : "")>inhereted</!option>
+          <!option value="" @(ThisChannel.LewdnessFilterLevel == null ? "selected" : "")>⤵ inherited - @Enumerations.GetDescription(IfInheritedLewdnessFilterLevel)</!option>
           @foreach (Enumerations.LewdnessFilterLevel enumVal in
           Enum.GetValues(typeof(Enumerations.LewdnessFilterLevel)))
           {
-            <!option value="@((int)enumVal)" @(Model.LewdnessFilterLevel == enumVal ? "selected" : "")>
+            <!option value="@((int)enumVal)" @(ThisChannel.LewdnessFilterLevel == enumVal ? "selected" : "")>
               @(Enumerations.GetDescription<Enumerations.LewdnessFilterLevel>(enumVal))</!option>
           }
         </select>
@@ -30,29 +36,29 @@
     </tr>
     <tr>
       <th scope="row">Links Allowed</th>
-      <td>@(Model.LinksAllowed?.ToString() ?? "unknown")</td>
+      <td>@(ThisChannel.LinksAllowed?.ToString() ?? "unknown")</td>
     </tr>
     <tr>
       <th scope="row">Lineage summary</th>
-      <td>@Model.LineageSummary</td>
+      <td>@ThisChannel.LineageSummary</td>
     </tr>
     <tr>
       <th scope="row">max attachment bytes</th>
-      <td>@Model.MaxAttachmentBytes (i hear there's "ByteSize")</td>
+      <td>@ThisChannel.MaxAttachmentBytes (i hear there's "ByteSize")</td>
     </tr>
     <tr>
       <th scope="row">max message length</th>
-      <td>@(Model.MaxTextChars?.ToString() ?? "inherited")</td>
+      <td>@(ThisChannel.MaxTextChars?.ToString() ?? "inherited")</td>
     </tr>
     <tr>
       <th scope="row">Meanness Filter Level</th>
       <td>
         <select name="MeannessFilterLevel" id="MeannessFilterLevel" onchange="patchModel(jsonifyChannel())">
-          <!option value="" @(Model.MeannessFilterLevel == null ? "selected" : "")>⤵ inhereted</!option>
+          <!option value="" @(ThisChannel.MeannessFilterLevel == null ? "selected" : "")>⤵ inherited - @Enumerations.GetDescription(IfInheritedMeannessFilterLevel)</!option>
           @foreach (Enumerations.MeannessFilterLevel enumVal in
           Enum.GetValues(typeof(Enumerations.MeannessFilterLevel)))
           {
-            <!option value="@((int)enumVal)" @(Model.MeannessFilterLevel == enumVal ? "selected" : "")>
+            <!option value="@((int)enumVal)" @(ThisChannel.MeannessFilterLevel == enumVal ? "selected" : "")>
               @(Enumerations.GetDescription<Enumerations.MeannessFilterLevel>(enumVal))</!option>
           }
         </select>
@@ -60,23 +66,23 @@
     </tr>
     <tr>
       <th scope="row">Messages (count)</th>
-      <td>@(Model.Messages?.Count ?? 0)</td>
+      <td>@(ThisChannel.Messages?.Count ?? 0)</td>
     </tr>
     <tr>
       <th scope="row">Protocol</th>
-      <td>@Model.Protocol</td>
+      <td>@ThisChannel.Protocol</td>
     </tr>
     <tr>
       <th scope="row">Reactions Possible</th>
-      <td>@(Model.ReactionsPossible?.ToString() ?? "inherited")</td>
+      <td>@(ThisChannel.ReactionsPossible?.ToString() ?? "inherited")</td>
     </tr>
     <tr>
       <th scope="row">Sub Channels</th>
-      <td>@(Model.SubChannels?.Count ?? 0)</td>
+      <td>@(ThisChannel.SubChannels?.Count ?? 0)</td>
     </tr>
     <tr>
       <th scope="row">Users</th>
-      <td>@(Model.Users?.Count ?? 0)</td>
+      <td>@(ThisChannel.Users?.Count ?? 0)</td>
     </tr>
   </tbody>
 </table>
@@ -85,7 +91,7 @@
 @section Scripts{
   <script type="text/javascript">
     @{
-      var modelAsString = JsonConvert.SerializeObject(Model, new JsonSerializerSettings
+      var modelAsString = JsonConvert.SerializeObject(ThisChannel, new JsonSerializerSettings
               {
                 ReferenceLoopHandling = ReferenceLoopHandling.Ignore
               });
@@ -97,7 +103,7 @@
       channelNow.ParentChannel = null;
       channelNow.Messages = null;
       channelNow.Users = null;
-      
+
       channelNow.LewdnessFilterLevel = document.querySelector("#LewdnessFilterLevel").value;
       channelNow.MeannessFilterLevel = document.querySelector("#MeannessFilterLevel").value;
       console.log(channelNow);